This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current CI setup hoists all deps to the root which makes it hard to spot when individual examples are missing dependencies. This change switches up CI to run the tests for each example in isolation so we should know when a dep is missing.
Hi @achingbrain It makes sense and I agree with you. But in my opinion we should test as a mono repo too, to check if the dependencies are being installed correctly (had problems in the past with Maybe we could have 2 build in parallel running as a mono repo and standalone. What do you think? However, I don't know if it will exceed the Github Action free tier 🤔 |
I've added this back in.
Me neither, I guess we'll find out 😆 |
oliveriosousa
approved these changes
Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CI setup hoists all deps to the root which makes it
hard to spot when individual examples are missing dependencies.
This change switches up CI to run the tests for each example in
isolation so we should know when a dep is missing.
It also better reflects how js-ipfs tests the examples in CI.